feat: Highlight and prioritize code definitions in grep results#299
Open
yashksaini-coder wants to merge 3 commits intodmtrKovalenko:mainfrom
Open
feat: Highlight and prioritize code definitions in grep results#299yashksaini-coder wants to merge 3 commits intodmtrKovalenko:mainfrom
yashksaini-coder wants to merge 3 commits intodmtrKovalenko:mainfrom
Conversation
dmtrKovalenko
requested changes
Mar 18, 2026
Owner
dmtrKovalenko
left a comment
dmtrKovalenko
left a comment
There was a problem hiding this comment.
Thank you for the contribution but I think we can make it even better
yashksaini-coder
force-pushed
the
feat/context-definition-detection
branch
3 times, most recently
from
1606258 to
5f722dc
Compare
yashksaini-coder
force-pushed
the
feat/context-definition-detection
branch
from
f87e12d to
43331dc
Compare
Author
|
@dmtrKovalenko can we run the CI/CD checks. I've updated the branch to latest commit |
Owner
|
Thank you. If you don’t mind I’ll push to your PR with some changes I’d like to tune how this feature feels |
Author
Sure why not works for me @dmtrKovalenko Would like to see your approach as well for improving the highlighting in grep |
Author
|
Hi @dmtrKovalenko follownig up on my PR, have you made any changes ? also I see some skipped workflows are they manual based for maintainers or reviewers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:- #297
This PR adds definition detection to the grep engine.
Kept it focused on definitions only for now to avoid messing with the UI for context lines.
@dmtrKovalenko