fix: fall back to git rev-parse in find_in_git_root#337
Conversation
|
I have deprecated find in git root because the current find automatically does that right? Or not? I’m really unsure what your expected behavior here |
|
Thanks for the quick review, @dmtrKovalenko! To clarify the intent of this fix: The The fix adds a secondary fallback: if Is this the scenario you intended to deprecate? If the new built-in Happy to follow whichever approach you prefer — close the PR if it is truly redundant, or adjust the implementation if you would like a different strategy. Let us know! |
|
Can you point me to the location of git rev parse head |
|
The |
|
oh I now understand this ! it is only happening on windows where we do not add libgit2 |
|
wait no we do have libgit2 enabled on windows, it is even statically linked can you please share your :checkhealth nvim |
Summary
git rev-parse --show-toplevelwhen the cached git root is still unavailableNotes
nvimandcargoare unavailable here.find_in_git_root()plus focused Lua tests.Closes #233