refactor(picker_ui): address resume feature review feedback (#438)#602
Merged
Conversation
…resume Address review feedback on #438: - Collapse last_file_picker_state/last_grep_picker_state/last_closed_mode into a single resume_state table. - Drop the fuzzy.get_base_path round-trip in close(); read base_path from the picker config directly. - Resuming with an active picker now closes and recreates it instead of bailing with a notify, so users can refresh stale results.
dmtrKovalenko
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #438 applying the three review notes from @dmtrKovalenko on top of current
main.Changes
last_file_picker_state/last_grep_picker_state/last_closed_modeinto oneresume_state = { files, grep, last_mode }table.fuzzy.get_base_path()round-trip inM.close(); readbase_pathfromM.state.configdirectly, as suggested in the review.resume()/resume_find_files()/resume_live_grep()now close the live picker and recreate it from the saved snapshot instead of bailing with a notify, so the user can refresh stale results in one keystroke.Steps to reproduce / verify
Confirmed
make lint-rustclean andstylua --checkclean on touched files. Lua linter was not run locally (lua5.4missing on the runner), CI will cover it.Automated triage via Gustav. Honk-Honk 🪿