test(node): add watcher churn stress target#604
Closed
ChengShiLiu16 wants to merge 1 commit into
Closed
Conversation
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Adds a focused Node SDK watcher churn stress target for the macOS FSEvents / debouncer crash reported in #603.
This does not claim to fix the crash. It gives maintainers a closer repro/diagnostic loop for the failing path: Node SDK + watcher enabled + concurrent filesystem churn + concurrent searches.
Changes
packages/fff-node/test/watcher-churn-stress.mjsFileFinderwith the watcher enabled/tmpmake test-node-watcher-stressmake build-c-lib-prof,make prepare-node-prof, andmake test-node-watcher-stress-profprofile.profprofile so macOS crashes can be reproduced with debuginfo/symbols retainedValidation
Local:
node --check packages/fff-node/test/watcher-churn-stress.mjsnpm ci --ignore-scriptscd packages/fff-node && npm run buildgit diff --checkmake -n test-node-watcher-stress-profNot run locally:
make test-node-watcher-stressmake test-node-watcher-stress-profReason: the local Rust toolchain currently has no usable
cargocomponent andrustuprolls back while installing due to arust-analyzercomponent conflict. The new Makefile targets expand correctly and should run in a working Rust environment / CI.Refs #603