Open
Conversation
CJCrafter
approved these changes
Aug 5, 2023
itz-rj-here
approved these changes
Aug 19, 2023
|
I can confirm this PR is needed to use TinyProtocol on 1.20.4. Someone should approve and merge this. |
itz-rj-here
approved these changes
Jan 12, 2024
Contributor
|
This doesn't fix TinyProtocol, this just fixes your use-case... TinyProtocol isn't maintained atm, and reviving it would require to update ALL packet types, not just one. |
What do you mean by use-case here? To my understanding, TinyProtocol doesn't use packet types. Instead, it intercepts the "raw" nms packets and forces you to handle the version specific code. This PR definitely fixes that in recent versions (though my testing was done quite a few versions ago). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2497