Fix Injector.getPlayer() using TemporaryPlayer when a Bukkit player is available#3614
Open
LeonTG wants to merge 1 commit intodmulloy2:masterfrom
Open
Fix Injector.getPlayer() using TemporaryPlayer when a Bukkit player is available#3614LeonTG wants to merge 1 commit intodmulloy2:masterfrom
LeonTG wants to merge 1 commit intodmulloy2:masterfrom
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

On my server I had a lot of issues where I was getting a temporary player for packets sent before PlayerJoinEvent, even tho Bukkit.getPlayerExact was returning the actual joined player
So I did some digging and I found out that even tho it returned the temporary player,
playerNamevariable was set, and with more digging it turns out that even if a bukkit player is available, doing getPlayer on the injector would never check for Bukkit player if a temporary player was already assignedso I decided to fix it myself, this is how I did it, and I figured I should make a PR for it, so others wont have this issue