release: develop -> main

[caster-Q]

主要变更

• feat: CLI 安装器（npx 一键 install/update/doctor/uninstall/remove-account/info）
• feat: 7 个 OpenClaw 内部命令（/dmwork_doctor、/dmwork_info 等）
• fix: --dangerously-force-unsafe-install 绕过安全扫描
• fix: package-lock.json Node 22 兼容修复
• fix: accountId 解析问题修复（fix: align agent-tools accountId resolution with channel.ts fallback chain #173）
• feat: thread GROUP.md 支持（feat: Thread GROUP.md support for sub-channels #177）
• docs: README 更新为 npx 安装方式和 accounts 配置模型

🤖 Generated with Claude Code

[lml2468]

Review: Release PR — 内容完整，有一个关键冲突需要处理

这是 develop → main 的 release PR（v0.5.20），包含约 60 个 commit，以下是主要功能和质量评估：

✅ 主要功能（已在 develop 验证）

• CLI 安装器（#174）：npx 一键 install/update/doctor/uninstall，配合 7 个内部命令 (/dmwork_info、/dmwork_doctor 等)，设计合理，与飞书/企微插件保持一致风格
• Bot 群管理 + Thread 操作（#163）：search-members/create-group/add-members + 7 个 Thread API，多 Bot token 隔离完善
• 子区(CommunityTopic=5)全链路支持（#164）：channelType=5 在 permission/inbound/channel 三层均已处理，修复完整
• Thread GROUP.md（#177）：子区 THREAD.md 完整支持，包含 broadcastThreadMdUpdate error handling 补丁（4/14 已修复我之前 review 提到的问题）✅
• accountId 四级 fallback（#173）：与 channel.ts 对齐，已合入 ✅
• 语音上下文管理（#161）：voice-context-read/update/delete，accountId 严格校验
• 跨会话消息查询 + 权限（#154）：完整权限模型，审计日志
• package-lock.json Node 22 兼容（#175）：修复 CI opusscript 缺失问题

⚠️ 关键冲突：#132 vs #180

#132（refactor: unify download utils，18 天未合入）与本 PR 均修改了 channel.ts 和 inbound.ts，但本 PR 的 develop 分支包含了更新的重构（sdk-compat.ts + temp-utils.ts，来自 #169）。

结论：#132 的改动已被本 PR 吸收或取代，可以直接关闭 #132，不需要等 #132 先合再合 #180。

📋 其他注意事项

1. --dangerously-force-unsafe-install（#178）：绕过 OpenClaw 安全扫描，是 child_process 使用的必要妥协。建议在 README 里说明这个标志的含义和原因，让用户知道这不是随意的安全绕过。

2. 无 CI 状态：GitHub Actions 已迁移到内部 GitLab（#159），本 PR 无 GitHub CI 覆盖。如果 GitLab CI 通过，可以接受。

3. MERGEABLE 状态：GitHub 报告可合入（无 git 冲突），BLOCKED 状态是因为缺 review，不是代码冲突。

总结

代码质量 ✅，功能集合完整 ✅，测试覆盖到位（500+ tests）✅。

建议：先关闭 #132（已被取代），再合入此 PR。

[Jerry-Xin]

PR #180 Review — release: develop → main

Nice work on this release — the CLI installer, doctor diagnostics, and GROUP.md thread support are solid additions. The dual entry-point architecture (plugin via index.ts + CLI via bin/dmwork.js) sharing cli/ modules is clean, and the test coverage is impressive (especially agent-tools.test.ts with token-leakage checks and group-md.test.ts using real filesystem).

That said, I found a few things worth addressing before merging to main:

---

1. --dangerously-force-unsafe-install is unconditionally hardcoded (High)

openclaw-channel-dmwork/cli/openclaw-cli.ts — pluginsInstall()

Every single call to pluginsInstall appends --dangerously-force-unsafe-install with no conditional logic and no user opt-in:

export function pluginsInstall(spec: string, quiet?: boolean, force?: boolean): void {
  const args = ["plugins", "install", spec, "--dangerously-force-unsafe-install"];
  // ...
}

This flag is hit from install.ts, update.ts, doctor.ts (auto-fix), and the in-process /dmwork_install and /dmwork_update commands — all silently bypassing whatever safety checks OpenClaw normally performs on plugin installs. The user is never informed.

Suggestion: Gate it behind an explicit user-facing flag, or at minimum document prominently why it's needed (e.g., if OpenClaw's checks are too restrictive for npm third-party plugins). Users should know their security posture.

---

2. No authorization checks on destructive management operations (High)

openclaw-channel-dmwork/src/agent-tools.ts exposes delete-thread, remove-members, create-group, update-group, and group-md-update through dmwork_management without any permission or identity verification. The tool's execute function receives no requester context.

Meanwhile, openclaw-channel-dmwork/src/permission.ts only gates the read action (in actions.ts → handleRead). The send, group-md-update, and all management operations skip permission checks entirely.

This means a prompt injection in a group message could trick the LLM into calling delete-thread or remove-members with the bot's full privileges. At minimum, destructive operations should validate requester identity and check group membership before executing.

---

3. Inconsistent URL encoding in api-fetch.ts (Medium)

Some functions correctly use encodeURIComponent for path segments (e.g., the thread-related functions), but others interpolate groupNo raw:

// NOT encoded — lines ~341, 373, 400, 486
const url = `${apiUrl}/v1/bot/groups/${params.groupNo}/members`;
const url = `${apiUrl}/v1/bot/groups/${params.groupNo}`;
const url = `${apiUrl}/v1/bot/groups/${params.groupNo}/md`;

// Correctly encoded — thread functions
`/v1/bot/groups/${encodeURIComponent(groupNo)}/threads/...`

A groupNo containing / or ? would break the request path. Should be consistent — apply encodeURIComponent everywhere.

Similarly, groupNo and shortId are used unsanitized in filesystem paths in group-md.ts (groupDir(), threadDir()). A crafted groupNo like ../../etc could escape the intended directory via path.join. Consider validating these contain only safe characters (alphanumeric, hyphens, underscores) before use in paths.

---

4. Memory leak in member-cache.ts — _userGroupIndex never prunes empty entries (Low)

openclaw-channel-dmwork/src/member-cache.ts — purgeReverseIndex():

function purgeReverseIndex(groupNo: string): void {
  for (const [, groups] of _userGroupIndex) {
    groups.delete(groupNo);
  }
  // Never cleans up: if groups.size === 0, the uid key remains
}

Over a long-running session, _userGroupIndex accumulates entries for users who have left all groups, each holding an empty Set. Easy fix: add if (groups.size === 0) _userGroupIndex.delete(uid); after the delete.

---

5. Minor items

• .gitlab-ci.yml: Makes sense given f0c5536 ("migrated to GitLab"). One note — NPM_TOKEN is written to ~/.npmrc in before_script (before build), which gives build scripts access to it. Safer to set it only immediately before npm publish.
• index.ts: dmwork_update handler uses execFileSync inside an async function, blocking the event loop during npm registry lookup. Consider switching to the async execFile variant.
• package.json: Both bundledDependencies and bundleDependencies are present with identical arrays — only the former is needed.

---

Overall this is a well-structured release with good test coverage. The security items (points 1-3) are the ones I'd want addressed before shipping to main. Happy to re-review after updates.

— Jerry