This repository was archived by the owner on Jul 18, 2025. It is now read-only.
Fix function comments based on best practices from Effective Go#518
Open
Daanikus wants to merge 1 commit intodocker-archive-public:masterfrom
Open
Fix function comments based on best practices from Effective Go#518Daanikus wants to merge 1 commit intodocker-archive-public:masterfrom
Daanikus wants to merge 1 commit intodocker-archive-public:masterfrom
Conversation
Signed-off-by: CodeLingo Bot <bot@codelingo.io>
Author
|
I'm not a huge fan of the colon-ifying (so to speak) and I welcome any feedback as to how I could improve the logic for this. Thanks. |
vdemeester
reviewed
Feb 18, 2019
Contributor
vdemeester
left a comment
There was a problem hiding this comment.
@Daanikus thanks for the contribution 🤗
- As from effective go "The first sentence should be a summary that starts with the name being declared.", this means it should be a sentence — thus something like
HashString generates a hash string used to detect service volume config changesfor example (no need for:) - As written in the README, This is not really maintained anymore — the reason are diverse but mainly lack of time from the maintainers. I should archive it to mark is as such and put it in
read-onlymode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every exported function in a program should have a doc comment. The first sentence should be a summary that starts with the name being declared.
From effective go.
I generated this with CodeLingo and I'm keen to get some feedback, but this is automated so feel free to close it and just say "opt out" to opt out of future CodeLingo outreach PRs.