This repository was archived by the owner on Oct 13, 2023. It is now read-only.
Add support for * for device name in --device#460
Open
aws-vrnatham wants to merge 2 commits intodocker-archive:masterfrom
Open
Add support for * for device name in --device#460aws-vrnatham wants to merge 2 commits intodocker-archive:masterfrom
aws-vrnatham wants to merge 2 commits intodocker-archive:masterfrom
Conversation
This takes care of the [issue](docker/cli#2968) from the server side Signed-off-by: Venky Natham <vrnatham@amazon.com>
Signed-off-by: Venky Natham <vrnatham@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This takes care of the issue from the server side
Signed-off-by: Venky Natham vrnatham@amazon.com
- What I did
Added code to look for * at the end of the device option
- How I did it
If it is there then it goes over all the devices that match that device and adds them to the spec.
- How to verify it
- Description for the changelog
This takes care of the issue from the server side
- A picture of a cute animal (not mandatory but encouraged)