Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/dclint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: docker-compose-linter/dclint-github-action@v1.3.0
- name: dclint
uses: docker-compose-linter/dclint-github-action/reviewdog-action@v1.3.0
with:
path: .
recursive: true
reporter: 'github-pr-review'
38 changes: 19 additions & 19 deletions docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,23 @@
name: Test Compose
version: '3.9'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [dclint] <no-version-field> reported by reviewdog 🐶
The "version" field should not be present.

reviewdog suggestion errorsource line (L=0) is not available for this suggestion

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [dclint] <require-project-name-field> reported by reviewdog 🐶
The "name" field should be present.


services:
b-service:
build:
context: ../../app/b-service
dockerfile: Dockerfile
target: builder
args:
- TEST1=${TEST}
- TEST2=${TEST}
container_name: b-service
depends_on:
- c-service
volumes:
- ../../app/flexible-forms-client/:/var/www/app
- /var/www/app/node_modules
ports:
- '127.0.0.1:11131:3000'
command: sh -c "npm run start"
a-service:
build:
context: ../../tests/a-service
Expand All @@ -22,24 +39,7 @@ services:
- '127.0.0.1:11032:3000'
command: sh -c "tail -f /dev/null"
expose:
- '3000'
b-service:
build:
context: ../../app/b-service
dockerfile: Dockerfile
target: builder
args:
- TEST1=${TEST}
- TEST2=${TEST}
container_name: b-service
depends_on:
- c-service
volumes:
- ../../app/flexible-forms-client/:/var/www/app
- /var/www/app/node_modules
ports:
- '127.0.0.1:11131:3000'
command: sh -c "npm run start"
- 3000
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [dclint] <require-quotes-in-ports> reported by reviewdog 🐶
Ports in ports and expose sections should be enclosed in quotes.

reviewdog suggestion errorsource line (L=0) is not available for this suggestion

c-service:
build:
context: ../../tests/c-service
Expand Down