Support aliases to urls #1581
Open
Support aliases to urls #1581
+6
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Gageot <david.gageot@docker.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review Summary
✅ LGTM - No issues found
This PR moves the URL reference check to occur after alias resolution, which is the correct approach. The change actually fixes a bug where aliases pointing to URLs would incorrectly fall through to NewOCISource() instead of being handled as URL sources.
Analysis
The key improvement:
- Before: URL check happened before
resolve(), so it only caught direct URL inputs - After: URL check happens after
resolve(), so it catches both direct URLs and URLs from resolved aliases
Since resolve() already preserves URLs as-is (via the check at line 163: if IsOCIReference(agentFilename) || IsURLReference(agentFilename)), this change maintains correct behavior for all cases while fixing the alias-to-URL scenario.
krissetto
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.