formatter: round CREATED durations consistently with Docker Desktop#6978
Open
texasich wants to merge 1 commit into
Open
formatter: round CREATED durations consistently with Docker Desktop#6978texasich wants to merge 1 commit into
texasich wants to merge 1 commit into
Conversation
Sync vendored HumanDuration semantics with docker/go-units PR docker#51: - add shared unit constants and roundDuration helper - round day/week/month/year outputs consistently - switch threshold checks to duration-based cutovers Add vendored duration tests covering boundary transitions and expected example outputs to guard against regressions in CREATED formatting. Refs: docker#6891
|
These are vendor generated files, not sure modifying these is acceptable or not. The root fix is in |
Author
|
good catch — agreed we should avoid hand-editing generated/vendor files when possible. i’ll rework this so the change comes from the non-vendored source path (or isolate the minimal safe workaround if upstream is effectively frozen), then update this PR with the exact provenance in the description so maintainers can audit it quickly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker/go-unitsHumanDuration rounding logic proposed in duration: extract roundDuration helper and round consistently go-units#51CREATEDoutputWhy
Fixes inconsistency reported in #6891 where CLI
CREATEDvalues diverge from Docker Desktop due to flooring vs rounding behavior.Scope notes
go-unitsduration formatting used by CLI outputValidation
GO111MODULE=off go test ./vendor/github.com/docker/go-units -run TestHumanDuration -count=1GO111MODULE=off go test ./vendor/github.com/docker/go-units -run ExampleHumanDuration -count=1Fixes #6891