Enable embeddedstructfieldcheck and godoclint linters#2188
Open
dgageot wants to merge 1 commit intodocker:mainfrom
Open
Enable embeddedstructfieldcheck and godoclint linters#2188dgageot wants to merge 1 commit intodocker:mainfrom
dgageot wants to merge 1 commit intodocker:mainfrom
Conversation
Add two new golangci-lint linters and fix all existing violations: - embeddedstructfieldcheck: enforce embedded fields at the top of structs with a blank line separating them from regular fields - godoclint: enforce godoc comments start with the symbol name and remove duplicate package comments The bulk of the changes are mechanical: adding a blank line after embedded fields in struct definitions, moving AgentContext to the top of event structs in pkg/runtime/event.go, and fixing godoc comments in pkg/hooks/types.go, pkg/tui/styles/styles.go, and pkg/app/app.go. Assisted-By: docker-agent
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR enables two new golangci-lint linters (embeddedstructfieldcheck and godoclint) and fixes all existing violations. The changes are purely mechanical and stylistic:
- Adding blank lines after embedded struct fields
- Moving
AgentContextto the top of event structs - Fixing godoc comments to start with symbol names
- Removing duplicate package comments
No functional bugs were found. The changes follow Go best practices and improve code consistency without affecting runtime behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two new golangci-lint linters and fix all existing violations:
The bulk of the changes are mechanical: adding a blank line after embedded fields in struct definitions, moving
AgentContextto the top of event structs inpkg/runtime/event.go, and fixing godoc comments inpkg/hooks/types.go,pkg/tui/styles/styles.go, andpkg/app/app.go.