Open
Conversation
Register github-copilot as an OpenAI-compatible provider alias pointing to https://api.githubcopilot.com with GITHUB_TOKEN for authentication. - Add alias entry in the Aliases map (pkg/model/provider) - Update agent-schema.json with the new provider example - Add examples/github-copilot.yaml - Simplify provider tests to be data-driven from Aliases map, removing the need to update tests when adding new providers Closes docker#2148 Assisted-By: docker-agent
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR correctly adds GitHub Copilot as a provider alias. The changes are well-structured:
✅ Provider alias properly configured with OpenAI-compatible API type
✅ Schema updated to include the new provider in the enum
✅ Example file demonstrates correct usage
✅ Tests refactored to be data-driven (excellent improvement!)
No bugs found in the changed code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register
github-copilotas an OpenAI-compatible provider alias pointing tohttps://api.githubcopilot.com with
GITHUB_TOKENfor authentication.Changes
Aliasesmap (pkg/model/provider)agent-schema.jsonwith the new provider exampleexamples/github-copilot.yamlAliasesmap, removing the need to update tests when adding new providersUsage
Closes #2148