Skip to content

mcp add false success#368

Open
Pnkcaht wants to merge 1 commit intodocker:mainfrom
Pnkcaht:fix/mcp-add-false-success
Open

mcp add false success#368
Pnkcaht wants to merge 1 commit intodocker:mainfrom
Pnkcaht:fix/mcp-add-false-success

Conversation

@Pnkcaht
Copy link
Copy Markdown
Contributor

@Pnkcaht Pnkcaht commented Jan 27, 2026

What I did

Updated the mcp-add tool response to avoid implying immediate tool availability after adding a server.

The response now reflects the actual behavior of MCP clients that do not automatically refresh the tool list, and clearly communicates how newly added tools can be accessed in the current session.

Related issue

Fixes #316

What was the problem?

The mcp-add tool reported success in a way that implied the server and its tools were immediately available to the client.

In practice:

  • Some clients (e.g. Claude Code) do not listen for tool list change notifications
  • /mcp or tool listings may not update until the client reconnects
  • This led to confusion and false-positive success reports, even though the server was correctly added

How this change fixes it

The success message was updated to be explicit and accurate:

  • It no longer assumes client-side tool list refresh
  • It explains that tools are available via mcp-exec in the current session
  • It instructs users to restart the MCP_DOCKER connection to load the updated tool list

This keeps server behavior unchanged while aligning user-facing output with real client behavior.

Before / After

Before

  • Success message implied tools were immediately usable
  • Users could believe the server was not added when tools were not visible

After

  • Success message matches actual MCP client behavior
  • Clear guidance on how to access tools and refresh the tool list

Signed-off-by: pnkcaht <samzoovsk19@gmail.com>
@Pnkcaht Pnkcaht requested a review from a team as a code owner January 27, 2026 22:15
@Pnkcaht
Copy link
Copy Markdown
Contributor Author

Pnkcaht commented Jan 27, 2026

Basically, it was just an added comment. Depending on what it is, I might do more about the issue mentioned, but I don't think there's much more I can do.

@slimslenderslacks
Copy link
Copy Markdown
Collaborator

@Pnkcaht Claude Code recently started processing the listChanged tool notification. Are you using any clients that are not refreshing the tool list today? I think this PR is a good idea - I'm just wondering which clients still rely on mcp-exec/client_restart.

@Pnkcaht
Copy link
Copy Markdown
Contributor Author

Pnkcaht commented Feb 3, 2026

@Pnkcaht Claude Code recently started processing the listChanged tool notification. Are you using any clients that are not refreshing the tool list today? I think this PR is a good idea - I'm just wondering which clients still rely on mcp-exec/client_restart.

@slimslenderslacks I understand your question and thank you for asking. As far as I know, all currently active clients process the listChanged notification automatically, therefore none of our current clients depend on mcp-exec/client_restart.

This pull request is primarily aimed at ensuring the safety of legacy or custom clients that may not update the list of tools automatically. It ensures that the message to the user correctly informs them about the need to restart the MCP_DOCKER connection, if necessary, without affecting modern clients :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug report: dynamic-tools mcp-add reports success but server is not actually added

3 participants