fix(gateway): update configuration before hot reload#384
Open
Pnkcaht wants to merge 2 commits intodocker:mainfrom
Open
fix(gateway): update configuration before hot reload#384Pnkcaht wants to merge 2 commits intodocker:mainfrom
Pnkcaht wants to merge 2 commits intodocker:mainfrom
Conversation
Signed-off-by: pnkcaht <samzoovsk19@gmail.com>
|
Hi @bobbyhouse can you merge this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
reloadConfigurationonly applies the given config and does not mutate global stateRelated issue
What changes now
MCP server not foundFlow (hot reload)
flowchart TD A[Config file updated] --> B[Watcher receives update] B --> C[Update g.configuration] C --> D[reloadConfiguration] D --> E[Tools / prompts / resources reloaded] E --> F[Gateway state consistent]