Improve error message when pulling a nonexistent catalog#439
Improve error message when pulling a nonexistent catalog#439jchangx wants to merge 3 commits intodocker:mainfrom
Conversation
Detect MANIFEST_UNKNOWN and NAME_UNKNOWN OCI registry errors and return a clear, concise message instead of the raw transport error.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b04de0a112
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
FullNameWithoutDigest strips digests and defaults to :latest, which would misreport the identifier for digest-based pulls.
xenoscopic
left a comment
There was a problem hiding this comment.
Clean, focused fix. The isNotFoundError helper correctly uses errors.As to unwrap through the OCI transport error chain and checks both MANIFEST_UNKNOWN and NAME_UNKNOWN codes. Test coverage is thorough including wrapped errors, non-matching transport errors, empty diagnostics, and mixed diagnostic lists. All CI green. LGTM.
Summary
MANIFEST_UNKNOWNandNAME_UNKNOWNOCI registry errors during catalog pullBefore:
After: