Error on duplicate profile ID instead of appending number suffix#455
Merged
Error on duplicate profile ID instead of appending number suffix#455
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ff909d1622
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
When creating a profile without an explicit ID, return an error if the derived ID already exists rather than silently appending _2, _3, etc. Removes the now-unused FindWorkingSetsByIDPrefix DB method. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
cmrigney
force-pushed
the
error-on-duplicate-profile-id
branch
from
ff909d1 to
779d285
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FindWorkingSetsByIDPrefixDAO method and replaces the auto-increment suffix logic with a hard error when a duplicate profile ID is detectedcreateWorkingSetIDto use a singleGetWorkingSetlookup and return an error if the ID already existsname_2,name_3, etc.)Test plan
make testpasses"already exists"error🤖 Generated with Claude Code