Open
Conversation
cutecatfann
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
ShouldUseGatewayOAuth(ctx,isCommunity) as the per-server decision function for whether the Gateway should own the OAuth lifecycle (localhost callback, PKCE, token storage) instead of delegating to Docker DesktopIsCEMode()unchanged for the notification monitor inpkg/gateway/run.go, which only needs the single global CE-vs-Desktop decisionThe existing
IsCEMode()is a binary global check: either the Gateway owns all OAuth, or Desktop owns all OAuth. This does not support the case where Desktop is running but a community-registered server (not in the Docker catalog) needs Gateway-managed OAuth.ShouldUseGatewayOAuthintroduces the per-server decision that downstream tickets will wire into individual call sites.Decision logic
When the Desktop backend is unreachable or the McpGatewayOAuth Unleash flag is not yet registered (MCPT-480 not deployed), the function returns false so callers fall back to Desktop OAuth rather than breaking.