Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to bundle the ZimaOS installer image into the container at build time and have the runtime install logic prefer that baked-in image when present, reducing reliance on downloading the image at container startup.
Changes:
- Add a build-time download of the installer QCOW2 into the image (
/img.qcow2) via the Dockerfile. - Update install flow to copy and boot from
/img.qcow2when available. - Redirect QEMU stdin to
/dev/nullwhen running in the background to avoid stdin-related hangs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/install.sh |
Prefer a baked-in QCOW2 image (/img.qcow2) as the boot source when no user-provided boot image is found. |
src/entry.sh |
Ensures background QEMU doesn’t read from stdin by redirecting stdin from /dev/null. |
Dockerfile |
Adds a build-time step to include the installer QCOW2 inside the container filesystem. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+130
to
+134
| if [ -s /img.qcow2 ]; then | ||
| cp /img.qcow2 "$STORAGE/" | ||
| ! bootFile "$STORAGE/img.qcow2" && exit 61 | ||
| return 0 | ||
| fi |
Comment on lines
+21
to
22
| ADD "https://github.com/zima-os/images/releases/download/v${VERSION_ARG}/zimaos-x86_64-${VERSION_ARG}_installer.qcow2" /img.qcow2 | ||
| COPY --chmod=755 ./src /run/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.