Skip to content

fix: split Linux CI into per-arch jobs to prevent native module mismatch #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abasiri merged 5 commits into from
Mar 26, 2026
Merged

fix: split Linux CI into per-arch jobs to prevent native module mismatch #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3e9815c
Upgrade Electron 33→41, electron-builder 25→26, better-sqlite3 11→12,…
abasiri Mar 25, 2026
9289565
Fix saving scroll position.
abasiri Mar 25, 2026
a0d2ad2
fix: split Linux CI into per-arch jobs to prevent native module misma…
abasiri Mar 25, 2026
123419e
fix: use --x64/--arm64 flags instead of --arch for electron-builder
abasiri Mar 25, 2026
7956fd5
fix: remove explicit arch from Linux targets, let electron-builder us…
abasiri Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,18 @@ jobs:
platform: mac
- os: windows-latest
platform: win
# Linux is split per-arch to avoid electron-builder bundling native
# modules from the wrong architecture. When multiple targets (AppImage
# + deb) are built for multiple arches in one invocation, the native
# module rebuild only runs between arch switches for the first target
# type — the second target type reuses whatever was last compiled,
# which can be the wrong arch. See #18.
- os: ubuntu-latest
platform: linux
arch: x64
- os: ubuntu-24.04-arm
platform: linux
arch: arm64

runs-on: ${{ matrix.os }}

Expand All @@ -47,7 +57,7 @@ jobs:

- name: Build (release)
if: startsWith(github.ref, 'refs/tags/v')
run: npm run release
run: npx electron-builder --${{ matrix.platform }} --publish always
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
CSC_LINK: ${{ matrix.platform == 'mac' && secrets.CSC_LINK || '' }}
Expand All @@ -67,7 +77,7 @@ jobs:
if: "!startsWith(github.ref, 'refs/tags/v')"
uses: actions/upload-artifact@v4
with:
name: dist-${{ matrix.platform }}
name: dist-${{ matrix.platform }}${{ matrix.arch && format('-{0}', matrix.arch) || '' }}
path: |
dist/*.dmg
dist/*.zip
Expand Down
Loading
Loading