Update AKS setup docs to use latest versions by default#332
Update AKS setup docs to use latest versions by default#332hossain-rayhan wants to merge 1 commit intodocumentdb:mainfrom
Conversation
Signed-off-by: Rayhan Hossain <rhossain@microsoft.com>
hossain-rayhan
requested review from
WentingWu666666,
alaye-ms and
xgerman
as code owners
There was a problem hiding this comment.
Pull request overview
Updates the AKS playground cluster creation script defaults to align with newer Kubernetes/operator expectations and adjusts the operator installation flow/documentation around version pinning.
Changes:
- Bumped the default AKS Kubernetes version to
1.35.0. - Removed hard-pinned operator chart/image version configuration and replaced it with commented “pin if desired” guidance.
- Updated the Helm OCI install logging/messages and removed some explicit
--setoverrides from the operator install command.
| if [ $? -eq 0 ]; then | ||
| success "DocumentDB operator installed successfully from ${OPERATOR_GITHUB_ORG}/documentdb-operator:${OPERATOR_CHART_VERSION}" | ||
| success "DocumentDB operator installed successfully from oci://ghcr.io/${OPERATOR_GITHUB_ORG}/documentdb-operator" | ||
| else | ||
| error "Failed to install DocumentDB operator from OCI registry. Please verify: | ||
| error "Failed to install DocumentDB operator. Please verify: | ||
| - Your GitHub token has 'read:packages' scope |
There was a problem hiding this comment.
This if [ $? -eq 0 ] block won’t run on helm install failure because the script uses set -e at the top; the shell will exit immediately on a non-zero status. Wrap the install in if helm install ...; then ... else ... fi (or temporarily disable set -e around it) so the intended error message is actually emitted.
WentingWu666666
left a comment
WentingWu666666
left a comment
There was a problem hiding this comment.
The Helm chart at oci://ghcr.io/documentdb/documentdb-operator is publicly accessible I verified that helm pull oci://ghcr.io/documentdb/documentdb-operator --version 0.2.0 succeeds without any authentication.
This means the GITHUB_TOKEN / GITHUB_USERNAME requirement and the helm registry login step (lines 374-394) are unnecessary and add friction for users. They'd need to create a GitHub PAT with read:packages scope just to install a public chart.
Suggestion: remove the auth block entirely, or make it optional (e.g., only required when OPERATOR_GITHUB_ORG is overridden to a private fork).
No description provided.