Open
Conversation
Includes fix for BASH_ENV not sourced when stdin is a Unix socket.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bumps go-basher to v5.1.8, which includes a fix I contributed (progrium/go-basher#53) for a bug where I think Bash 5.x silently skips sourcing
BASH_ENVwhen stdin is a Unix socket. This causesmain: command not found(exit 127) errors in plugn commands when the calling process has a socket as stdin — which I believe comes up with process supervisors, systemd socket activation, etc.I think this is the same root cause as dokku/dokku#5764.
The fix explicitly sources the envfile in the
-ccommand string instead of relying solely onBASH_ENV, which should resolve the issue.Test plan