[pull] master from php:master#561
Merged
Merged
Conversation
The schedule and workflow_dispatch triggers should imply all jobs.
* PHP-8.2: Fix nightly job selection Fix ccache in pecl job
* PHP-8.3: Fix nightly job selection Fix ccache in pecl job
* PHP-8.4: Fix nightly job selection Fix ccache in pecl job
* PHP-8.5: Fix nightly job selection Fix ccache in pecl job
Just like brew this can stall, apparently...
* PHP-8.2: [skip ci] Limit "Update clang" step to 10 minutes
* PHP-8.3: [skip ci] Limit "Update clang" step to 10 minutes
* PHP-8.4: [skip ci] Limit "Update clang" step to 10 minutes
* PHP-8.5: [skip ci] Limit "Update clang" step to 10 minutes
The repeated request will re-use the connection from the first one, failing the connect_time check.
* PHP-8.5: [skip ci] Mark curl_persistent_share_002.phpt as not repeatable
* PHP-8.2: [skip ci] Disable redis in pecl build [skip ci] Re-enabled xdebug in nightly job
* PHP-8.3: [skip ci] Disable redis in pecl build [skip ci] Re-enabled xdebug in nightly job
* PHP-8.4: [skip ci] Disable redis in pecl build [skip ci] Re-enabled xdebug in nightly job
* PHP-8.5: [skip ci] Disable redis in pecl build [skip ci] Re-enabled xdebug in nightly job
Then we can unify root.yml and push.yml. Closes GH-21249
* PHP-8.2: Move benchmarking job to nightly
* PHP-8.3: Move benchmarking job to nightly
* PHP-8.4: Move benchmarking job to nightly
* PHP-8.5: Move benchmarking job to nightly
* PHP-8.2: [skip ci] Add missing benchmarking checkout ref
* PHP-8.3: [skip ci] Add missing benchmarking checkout ref
* PHP-8.4: [skip ci] Add missing benchmarking checkout ref
* PHP-8.5: [skip ci] Add missing benchmarking checkout ref
Testing for numRows is redundant as this method isn't implemented. It was probably meant once to be implemented at some point in the future when migrating from ext/sqlite to ext/sqlite3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )