[pull] master from php:master#832
Merged
Merged
Conversation
PS_VALIDATE_SID_FUNC(mm) was missing the semicolon after the ps_mm_key_exists() assignment, so ext/session/mod_mm.c failed to compile under --with-mm. The file is gated behind HAVE_LIBMM, so default builds and CI never exercised it. Closes GH-22336
php_zval_filter() copies the filtered value so it can be quoted in the FilterFailedException message, then released the copy with zend_string_delref(), which only decrements the refcount. When the input is a non-string scalar that convert_to_string() turns into a fresh heap string, the copy was the sole owner and leaked one string per call on both the failure and the success path. Use zend_string_release() so it is freed at refcount zero. Closes GH-22339
* PHP-8.5: Fix leak of preserved input string with FILTER_THROW_ON_FAILURE
php_libxml_sniff_charset_from_string() advanced the parse cursor by the parameter name length after collecting an unquoted parameter value (WHATWG mime-sniff step 11.9.1), instead of the value length. When a Content-Type parameter before charset had a name and value of different lengths, the cursor misaligned and the charset parameter was missed, so document loading fell back to the wrong encoding. Closes GH-22343
* PHP-8.4: Fix MIME charset sniffing advancing by name length not value length
* PHP-8.5: Fix MIME charset sniffing advancing by name length not value length
…ed place to get help (#22333) The discord server is now mostly used in discussion rather then the IRC channel. Good to document it as a way to get help in CONTRIBUTING.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )