fix dolt push hanging on ssh askpass credential prompts#11034
Open
elianddb wants to merge 3 commits into
Open
Conversation
Contributor
|
@elianddb DOLT
|
Contributor
Contributor
Contributor
macneale4
requested changes
Jun 15, 2026
macneale4
left a comment
Contributor
There was a problem hiding this comment.
This seems like the wrong fix. It just disables the ability to use SSH_ASKPASS and the others. I don't think that's what the user wants - I would suspect they want to be prompted.
If a user has set that environment variables, they don't want us to silently ignore them. That's counter intuitive, and possibly harmful. We either need to print a loud message that we don't support these things and exit with a failure, or they need to work as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dolt pushover git+ssh could hang forever when ssh routed a credential prompt to an SSH_ASKPASS program.Fix dolt push to git+ssh GitHub remote hangs on Linux/WSL2 #11027