fix(sql): warn when dolt_checkout used as single -q statement#11045
Open
superShen0916 wants to merge 3 commits into
Open
fix(sql): warn when dolt_checkout used as single -q statement#11045superShen0916 wants to merge 3 commits into
superShen0916 wants to merge 3 commits into
Conversation
When 'dolt sql -q "call dolt_checkout(...)"' is run as a single statement, the branch change does not persist because each -q invocation uses its own session. Print a warning to help users understand this behavior. Fixes dolthub#6876 Signed-off-by: shenpeng.sp0916 <shenpeng.sp0916@bytedance.com>
macneale4
reviewed
May 28, 2026
macneale4
left a comment
macneale4
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution! Please address the feedback and add a bats tests in the sql.bats file to verify that the warning shows once per invocation. Thanks again!
Use sync.Once so the warning is emitted at most once across all -q invocations. Move the regression test from sql-checkout.bats into sql.bats per review feedback, and cover the multiple -q case. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6876 - When
dolt sql -q "call dolt_checkout('branch');"is run as a single statement, the branch change does not persist because each-qinvocation uses its own session. This PR adds a warning to help users understand this behavior.Changes
go/cmd/dolt/commands/sql.go: Added warning inqueryMode()when query containsdolt_checkout