Fix line comments in literal column names#11160
Open
puneetdixit200 wants to merge 1 commit into
Open
Conversation
Member
|
Thanks for the contribution. This change is in the right direction, but this fix is applied at the wrong place. We don't want to do this processing in the dolt SQL shell, as that doesn't fix the underlying problem of column names at the server layer. Rather, this fix should take place in dolthub/vitess at the same time that we capture the query text for column aliasing purposes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10868.
Summary
Verification
TestSignAndVerifyCommitrequiresgpg, which is not installed in this environment.