Skip to content

Fix spurious unique key error when staging workspace rows#11269

Open
elianddb wants to merge 1 commit into
mainfrom
elian/11195
Open

Fix spurious unique key error when staging workspace rows#11269
elianddb wants to merge 1 commit into
mainfrom
elian/11195

Conversation

@elianddb

@elianddb elianddb commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Staging a delete and an insert that reuse the same unique key via dolt_workspace_* failed with a spurious duplicate unique key error, because rows were applied in workspace order and checked per row.

@elianddb elianddb force-pushed the elian/11195 branch 2 times, most recently from 0782d57 to b0e4621 Compare July 2, 2026 18:45
@coffeegoddd

coffeegoddd commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

@elianddb DOLT

read_tests from_latency to_latency percent_change
covering_index_scan 2.3 2.3 0.0
groupby_scan 142.39 139.85 -1.78
index_join 1.93 1.93 0.0
index_join_scan 1.3 1.3 0.0
index_scan 215.44 215.44 0.0
oltp_point_select 0.25 0.25 0.0
oltp_read_only 4.91 4.91 0.0
select_random_points 0.5 0.5 0.0
select_random_ranges 0.63 0.62 -1.59
table_scan 207.82 207.82 0.0
types_table_scan 467.3 475.79 1.82
write_tests from_latency to_latency percent_change
oltp_delete_insert 6.09 6.09 0.0
oltp_insert 3.13 3.13 0.0
oltp_read_write 11.04 11.04 0.0
oltp_update_index 3.25 3.25 0.0
oltp_update_non_index 2.97 2.97 0.0
oltp_write_only 6.21 6.21 0.0
types_delete_insert 6.79 6.79 0.0

@coffeegoddd

coffeegoddd commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

@elianddb DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 44.17 45.79 3.67
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt 2a5c6c2 53.4 dolt 061c640 53.42 0.04

@elianddb elianddb changed the title fix spurious unique key error when staging workspace rows Fix spurious unique key error when staging workspace rows Jul 2, 2026
@elianddb

elianddb commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

#benchmark

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

@coffeegoddd

Copy link
Copy Markdown
Contributor

@elianddb DOLT

comparing_percentages
100.000000 to 100.000000
version result total
061c640 ok 5937471
version total_tests
061c640 5937471
correctness_percentage
100.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spurious UNIQUE key failure when staging rows in workspace (fixed by staging individually)

2 participants