Skip to content

feature/time_variable_in_output_files#12

Merged
jsauer-NCAR merged 1 commit intodevelopfrom
feature/time_variable_in_output_files
Mar 28, 2025
Merged

feature/time_variable_in_output_files#12
jsauer-NCAR merged 1 commit intodevelopfrom
feature/time_variable_in_output_files

Conversation

@jsauer-NCAR
Copy link
Copy Markdown
Collaborator

Implemented output of a float value for time in netCDF or binary output files, also ensured strict update of master simTime to be a perfect multiple of dt (avoiding roundoff error in simTime) and implemented the ability to read/write int variables in the netcdf and binary modes of the IO module to allow for upcoming TVCP parameters.

Expected Differences

  • [No ] Do these changes introduce new tools, command line arguments, or configuration file options? [Yes or No]

    If yes, please describe:

Pull Request Testing

  • [x ] Describe testing already performed for these changes:

    Verfied clean (even multiple of dt) float values of time variable in output files
  • [x ] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    None
  • [x ] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
    N/A
  • [x ] Do these changes include sufficient testing updates? [Yes or No]
    N/A
  • [ x] Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

    N/A
  • [x ] Please complete this pull request review by [Fill in date].

    N/A

Pull Request Checklist

  • [ x] Complete the PR definition above.
  • [ x] Ensure the PR title matches the feature or bugfix branch name.
  • [x ] Select: Reviewer(s)
  • [ x] After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…ut files, also ensured strict update of master simTime to be a perfect multiple of dt (avoiding roundoff error in simTime) and implemented the ability to read/write int variables in the netcdf and binary modes of the IO module to allow for upcoming TVCP parameters.
@jsauer-NCAR jsauer-NCAR merged commit 93693af into develop Mar 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant