Skip to content

Use TKE_0 for boundary conditions in LAD runs#21

Merged
jsauer-NCAR merged 1 commit intodevelopfrom
feature/nesting_tke
Mar 12, 2026
Merged

Use TKE_0 for boundary conditions in LAD runs#21
jsauer-NCAR merged 1 commit intodevelopfrom
feature/nesting_tke

Conversation

@domingom
Copy link
Copy Markdown
Owner

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [Yes or No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]

  • Do these changes include sufficient testing updates? [Yes or No]

  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Select: Reviewer(s)
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@domingom domingom requested a review from jsauer-NCAR March 12, 2026 17:59
Copy link
Copy Markdown
Collaborator

@jsauer-NCAR jsauer-NCAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at all of this closely and everything appears good to go. Approving and merging.

@jsauer-NCAR jsauer-NCAR merged commit b59f712 into develop Mar 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants