Niole.dom 75352.disable in memory jobs#18
Conversation
| } | ||
| /> | ||
| <Select | ||
| <Input |
There was a problem hiding this comment.
Disabled the input for selecting the execution target
There was a problem hiding this comment.
Looks good. The Select→disabled Input swap is clean. One note: the hardcoded value="Domino Job" is a display string if the backend expects "domino_job" and something reads this input's value, it'll mismatch. But since the input is disabled and not bound to state, this is fine as purely cosmetic.
| * use that host for all links. | ||
| * - Otherwise, derive the tenant host from window.location by stripping an apps. prefix. | ||
| */ | ||
| export function toDominoTenantUrl(rawUrl?: string): string | null { |
There was a problem hiding this comment.
Refactored this to domino tenant url function to also use domino_api_host if provided, while in dev mode. This makes testing the UI easier in dev mode
There was a problem hiding this comment.
The VITE_DEV_DOMINO_API_HOST approach for dev mode is sensible. One thing: the env var name in vite.config.ts is VITE_DEV_DOMINO_API_HOST but in vite-env.d.ts the type declaration is for VITE_DOMINO_API_HOST
2 participants
JIRA https://dominodatalab.atlassian.net/browse/DOM-75352
This pr disables the ability for the user ot choose to run local jobs, but doesn't change the backend code
This also adds a helper for rendering links so that they point to the domino api host if the app runs in dev mode. this makes clicking on links to jobs actually work in dev