[DOM-75518] feat: dataset listing API client + HTTP layer extensions#24
Open
ddl-subir-m wants to merge 3 commits intomainfrom
Open
[DOM-75518] feat: dataset listing API client + HTTP layer extensions#24ddl-subir-m wants to merge 3 commits intomainfrom
ddl-subir-m wants to merge 3 commits intomainfrom
Conversation
ddl-subir-m
changed the title
5 tasks
niole
approved these changes
Mar 23, 2026
- Add DominoProjectType enum (DFS/GIT/UNKNOWN) with filesystem-based detection - Add _db_url_remap for cross-project SQLite URL remapping across mount types - Add tabular_data module: centralized CSV/parquet preview, schema, row counting with LRU caching (replaces scattered pd.read_csv/parquet calls) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…leware - domino_dataset_api.py: typed listing wrapper (v2→v1 fallback) using generated client - domino_http.py: add params/files/headers/base_url to domino_request, streaming download - middleware.py: debug request/response logging with header redaction - project_resolver.py: use generated get_project_by_id endpoint Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ddl-subir-m
force-pushed
the
subir/pr17-listing-api
branch
from
49ef803 to
eab762f
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Replaces the domino-py SDK's dataset listing with a typed wrapper around the generated Domino Public API client. This gives us version-safe, structured access to the Dataset RW v1/v2 listing endpoints with automatic pagination and v2→v1 fallback.
Summary
domino_dataset_api.py: typed listing wrapper using generated client (get_datasets_v2.sync(),get_datasets.sync()) with pagination and v2→v1 fallbackproject_resolver.py: switched from internal/v4/projectsto generatedget_project_by_id(public v1 API)Stacks on PR #14 (HTTP layer) + PR #12 (project type + tabular data).
Replaces old PR #17 — trimmed to only the listing API infrastructure. Storage resolver and its consumers moved to PRs #25/#26.
Files changed
domino_dataset_api.pyproject_resolver.pyget_project_by_idinstead of raw/v4/projectsAll code in this PR is consumed by PR #25 (
dataset_manager.pyandstorage_resolver.pyimport fromdomino_dataset_api).Test plan
test_domino_dataset_api.pypassestest_middleware.pypassestest_domino_http.pypasses