Add FileDownloadConfig annotation for FlyteFile inputs#8
Open
ddl-rliu wants to merge 2 commits into1.15.4-dominofrom
Open
Add FileDownloadConfig annotation for FlyteFile inputs#8ddl-rliu wants to merge 2 commits into1.15.4-dominofrom
ddl-rliu wants to merge 2 commits into1.15.4-dominofrom
Conversation
Port new BlobType fields file_extension and enable_legacy_filename to flytekit.
FlyteFile inputs can be annotated with the FileDownloadConfig annotation to
configure the file extension to use during the copilot download phase.
e.g.
```python
def t1(file: Annotated[FlyteFile, FileDownloadConfig(file_extension="csv")]):
... # copilot downloads the file to e.g. /inputs/file.csv
versus...
def t1(file: FlyteFile["csv"]):
... # copilot downloads the file to e.g. /inputs/file
```
3 tasks
ddl-rliu
commented
Mar 26, 2026
ddl-rliu
force-pushed
the
rliu.DOM-75010.file-ext3
branch
from
b38b9d3 to
3d21883
Compare
ddl-s-ramirezayuso
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream: flyteorg#3406
Port new BlobType fields file_extension and enable_legacy_filename to flytekit. FlyteFile inputs can be annotated with the FileDownloadConfig annotation to configure the file extension to use during the copilot download phase.
e.g.
Full context at flyteorg/flyte#7009
Tracking issue
Closes flyteorg/flyte#7024
Why are the changes needed?
What changes were proposed in this pull request?
https://github.com/cerebrotech/train-flyteadmin-docker/pull/121
https://github.com/cerebrotech/train-flytecopilot-docker/pull/101
#8
#9
https://github.com/cerebrotech/train-flyte-library/pull/78
https://github.com/cerebrotech/compute-environment-builder/pull/933
Changes manually tested at https://github.com/cerebrotech/compute-environment-builder/pull/933#issue-4139089260
see also
dominodatalab/flyte#2
dominodatalab/flyte#3
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link