Skip to content

Conversation

@doneill
Copy link
Owner

@doneill doneill commented Aug 17, 2025

Proposed Changes

  • Reorder patrols display table
    • Move patrol segment id to end of display
  • Limit patrol --days value to 30
    • Most patrol activity is typically queried for recent periods (1-14 days)
    • Add page_size to get manageable response data
  • Handle errors in all requests

Expectation:
Usage Examples

Valid usage:

er patrols -d 7   # ✅ Default, works fine
er patrols -d 30  # ✅ Maximum allowed
er patrols -d 15  # ✅ Within limit

Invalid usage with helpful errors:

er patrols -d 31  # ❌ "days value cannot exceed 30 to prevent timeouts (got 31)"
er patrols -d -5  # ❌ "days value must be positive (got -5)"

add page size to account for multi-page responses, limit 200
@doneill doneill self-assigned this Aug 17, 2025
@doneill doneill merged commit 963b4b3 into develop Aug 17, 2025
1 check passed
@doneill doneill deleted the task/jdo-45-reduce-patrols-data branch August 17, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants