fix: hide Create new account button when signup is disabled#77
Open
Vi-Ku wants to merge 1 commit intodonetick:mainfrom
Open
fix: hide Create new account button when signup is disabled#77Vi-Ku wants to merge 1 commit intodonetick:mainfrom
Vi-Ku wants to merge 1 commit intodonetick:mainfrom
Conversation
When is_user_creation_disabled is true in the /resource API response, hide the 'Create new account' button on the login page entirely instead of showing it and blocking with an error after the form is filled. Fixes: donetick/donetick#602
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hides the "Create new account" button on the login page when
is_user_creation_disabledistrue, instead of showing the button and blocking with an error after the signup form is filled.Changes
Related
is_user_creation_disabledin the/resourceendpoint)Before / After
Before: The "Create new account" button is always visible, and clicking it leads to a signup form that returns a 403 error when signup is disabled — confusing for users.
After: When
is_user_creation_disabledistrue, the button is hidden entirely from the login page.