Fixed relative StringTables indexes#113
Open
moofMonkey wants to merge 1 commit intodotabuff:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AFAIK they're not used at CSVCMsg_CreateStringTable, but they're used at almost every CSVCMsg_UpdateStringTable.
I noticed this issue when I've tried to parse modifiers (CDOTAModifierBuffTableEntry) out of ActiveModifiers table - there were wrong list of them.
Things that helped this fix to land:
dumpstringtable ActiveModifiers cl verbosecl_dota_dump_modifier_stringtabledebug macos dota binaries (first call of bf_write::WriteVarInt32 inside CNetworkStringTable::WriteUpdate)