Draft
Conversation
🦋 Changeset detectedLatest commit: d1b4ed0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Thank you for your maintenance @eddeee888, much love! ❤️ |
eddeee888
force-pushed
the
bump-codegen-deps
branch
2 times, most recently
from
8f2be4e to
4e18a96
Compare
eddeee888
commented
Mar 6, 2026
Comment on lines
+162
to
+163
| baseType: this.scalars[schemaType.name].input, | ||
| typeName: this.scalars[schemaType.name].input, |
Collaborator
Author
There was a problem hiding this comment.
These are best guess based on function name. If something's wrong, happy to change!
eddeee888
commented
Mar 6, 2026
Comment on lines
+157
to
+158
| baseType: this.scalars[schemaType.name].input, | ||
| typeName: this.scalars[schemaType.name].input, |
Collaborator
Author
There was a problem hiding this comment.
These are best guess based on function name. If something's wrong, happy to change!
eddeee888
commented
Mar 6, 2026
Comment on lines
+78
to
+79
| if (this.scalars[type.name.value]?.output) { | ||
| return this.scalars[type.name.value].output; |
Collaborator
Author
There was a problem hiding this comment.
These are best guess based on function name. If something's wrong, happy to change!
eddeee888
commented
Mar 6, 2026
|
|
||
| const transformScalar = (scalar: string) => { | ||
| if (DEFAULT_SCALARS[scalar] === undefined) { | ||
| if (DEFAULT_SCALARS[scalar]?.output === undefined) { |
Collaborator
Author
There was a problem hiding this comment.
These are best guess based on function name. If something's wrong, happy to change!
eddeee888
commented
Mar 6, 2026
Comment on lines
-43
to
-59
| it('should import DocumentNode when using noGraphQLTag', async () => { | ||
| const docs = [{ location: '', document: basicDoc }]; | ||
| const content = (await plugin( | ||
| schema, | ||
| docs, | ||
| { | ||
| noGraphQLTag: true, | ||
| }, | ||
| { | ||
| outputFile: 'graphql.tsx', | ||
| }, | ||
| )) as Types.ComplexPluginOutput; | ||
|
|
||
| expect(content.prepend).toContain(`import { DocumentNode } from 'graphql';`); | ||
| expect(content.prepend).not.toContain(`import gql from 'graphql-tag';`); | ||
| await validateTypeScript(content, schema, docs, {}); | ||
| }); |
Collaborator
Author
There was a problem hiding this comment.
noGraphQLTag has been deprecated so no need for this test
eddeee888
force-pushed
the
bump-codegen-deps
branch
from
1840300 to
d1b4ed0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This repo has some old devDeps in packages. This PR updates them all to the latest.
Depending on the use case, some may have breaking changes.
Changes
@graphql-codegen/testingv4@graphql-codegen/flow,@graphql-codegen/flow-operationsand@graphql-codegen/flow-resolverspackages because they depend on a CJS builtflow.jsfile, and I don't know where it comes from@graphql-codegen/plugin-helpersto ^6.0.0 and@graphql-codegen/visitor-plugin-commonto ^6.0.0@graphql-codegen/flow,@graphql-codegen/flow-operationsand@graphql-codegen/flow-resolversbecause they cannot be tested (See 1.)@graphql-codegen/typescript-nestand@graphql-codegen/typescript-type-graphqlbecause it's too hard to fix the tests@graphql-codegen/typescript-react-apolloas we have plans to deprecate it. Releasing a major right now may give the wrong signal to users