Server-triggered circuit pause section updates#37146
Conversation
|
@tdykstra @wadepickett ... This popped up here ... aspnetcore/host-and-deploy/health-checks.md aspnetcore/host-and-deploy/health-checks/includes/health-checks6-7.md No worries! I'll fix it on this PR. |
|
Ah!!! @tdykstra, @wadepickett ... and looping in @BillWagner (👋 Bill ... hope ur well!!!) ..... There's an API Browser regression. The API for ... ... shows up ...
... but there's no API for it. Clicking the link results in a 404 ...
I'm going to code-fence the API in these markdown files for now to unblock this PR. I'll open a new issue to put the XREF links back after the API Browser comes back online with the bits. UPDATE: Done! 👍 I've opened ... Reactivate XREF cross-links after API Broswer regression is addressed ... to reactivate the XREF cross-links in the markdown files after the API shows back up. |
wadepickett
left a comment
There was a problem hiding this comment.
@guardrex, approved. Looks great. One crucial item in the code to fix before you merge. I noted it inline.
Co-authored-by: Wade Pickett <wpickett@microsoft.com>
|
Thanks for spotting that, @wadepickett! |
|
@guardrex, For Microsoft.Extensions.DependencyInjection.EntityFrameworkCoreHealthChecksBuilderExtensions.AddDbContextCheck: It does exist in the API Ref: Looks like the xref cross-reference sysetem can't resolve the wildcard link? So by regression, you mean the xref cross-ref system used to handle wildcards like this but now they are not resolving, correct? (As opposed to the API Ref regressing and a once documented reference item is now missing) |
|
Not sure. Let me check again on that. Maybe it was a passing problem. |
I think so. I'm going by the build report and the 404 in the API Browser. The build report threw ... I suggest that we code-fence for now to unblock this and go back to the proper XREF links, which is tracked by #37147. If you and Tom want, I'll babysit that issue until this is sorted out. In passing tho, I still disagree that a build report warning in an unrelated article should block a PR. I think that's a poor process choice. |
|
"In passing tho, I still disagree that a build report warning in an unrelated article should block a PR. I think that's a poor process choice." I do not think a build report warning on an unrelated article should ever block a PR. We are on the same page. |
|
I'll go ahead with this so that we have a great example from Ilona on how to implement the new API. I'll take that issue that I opened and keep an eye on the API Browser. I think Alma Jenks was helping us with these API-related problems. I'll ping him on that issue to ask about it. However, let me know if he's the wrong cat to discuss it with. |
|
Intersting: |
|
Yes, that's what I'm seeing here. Let's take this up on the issue that I opened at #37147. |



Fixes #37145
Wade, this comes from Ilona's feedback on #37133. She's OOF at the moment, and we can go ahead with this based on your review. When she sees my remarks below, she can comment on if I broke anything with my updates. If I did break something, I'll issue a patch PR later, probably sometime next week.
Ilona ... Thanks so much for the implementation updates to Javier's original code. I think devs are really going to ❤️ this feature and the implementation example that you provided. You don't need to look at the whole thing, but this one paragraph might need a little more work. I applied some grammar and style manual updates that might have 💥 some of the concepts 🙈😆. That paragraph currently goes like this (Line 229 on the diff) ...
Internal previews