Replace external PublishSymbols task with SymbolUploadHelper-based task (WI 10148/10149)#16691
Open
missymessa wants to merge 2 commits intomainfrom
Open
Replace external PublishSymbols task with SymbolUploadHelper-based task (WI 10148/10149)#16691missymessa wants to merge 2 commits intomainfrom
missymessa wants to merge 2 commits intomainfrom
Conversation
…sk (WI 10148/10149) Replaces the Microsoft.SymbolUploader.Build.Task dependency in PublishToSymbolServers.proj with a new PublishSymbolsUsingSymbolUploadHelper MSBuild task that uses the proven internal SymbolUploadHelper infrastructure already used by Maestro promotion publishing. Key changes: - New task PublishSymbolsUsingSymbolUploadHelper in Build.Tasks.Feed that wraps SymbolUploadHelper - Supports both PAT auth (backward compat) and DefaultIdentityTokenCredential (Entra/MI) - Updated PublishToSymbolServers.proj to use the new task and reference Build.Tasks.Feed - SymbolServerTargets now use org names (microsoft, microsoftpublicsymbols) instead of URLs Migration path: When PATs are still configured, PAT auth is used automatically. When PATs are removed, DefaultIdentityTokenCredential provides Entra auth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the external \Microsoft.SymbolUploader.Build.Task\ dependency in \PublishToSymbolServers.proj\ with a new \PublishSymbolsUsingSymbolUploadHelper\ MSBuild task that uses the proven internal \SymbolUploadHelper\ infrastructure already used by Maestro promotion publishing.
Motivation
WI 10148 (\microsoft-symbol-server-pat) and WI 10149 (\symweb-symbol-server-pat) track the migration of PATs used for symbol publishing to Entra/managed identity auth. The current \PublishToSymbolServers.proj\ uses an external task that only accepts a \PersonalAccessToken\ string parameter, with no support for \TokenCredential-based auth.
The internal \SymbolUploadHelper\ (used by Maestro/Darc promotion) already supports \TokenCredential, making it the natural choice for the migration.
Changes
*New task \PublishSymbolsUsingSymbolUploadHelper* in \Microsoft.DotNet.Build.Tasks.Feed:
**Updated \PublishToSymbolServers.proj**:
Migration Path
Testing
Related: AB#10148, AB#10149