Skip to content

Add xLocCustomPowerShellScript in OneLoc task#16693

Open
martinrrm wants to merge 1 commit intomainfrom
martinrrm-add-customscript-oneloc
Open

Add xLocCustomPowerShellScript in OneLoc task#16693
martinrrm wants to merge 1 commit intomainfrom
martinrrm-add-customscript-oneloc

Conversation

@martinrrm
Copy link
Copy Markdown

To double check:

Needed for NuGet.Client change NuGet/NuGet.Client#7259.

We use OneLoc to localize our strings, unfortunately OneLoc returns the files with BOM, and when moved to VMR BOM is removed, creating a "back and forth" PR creation between VMR and OneLoc, examples: https://github.com/NuGet/NuGet.Client/pull/7256/changes
https://github.com/NuGet/NuGet.Client/pull/7251/changes

@akoeplinger
Copy link
Copy Markdown
Member

hmm we don't have that issue in any other repo as far as I know. Are you sure you don't have some .gitattributes setting that strips the BOM?

@martinrrm
Copy link
Copy Markdown
Author

@akoeplinger Interesting, let me investigate that. I reach out to OneLoc folks, and this is what they suggested. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants