Remove legacy launch-mirrors Key Vault fallback (WI 10088)#16701
Open
missymessa wants to merge 1 commit intomainfrom
Open
Remove legacy launch-mirrors Key Vault fallback (WI 10088)#16701missymessa wants to merge 1 commit intomainfrom
missymessa wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the legacy UseKeyVault fallback from scripts/launch-mirrors.ps1.
For WI 10088, investigation showed the dn-bot-all-build-queue PAT is dormant/manual-only, the related dnceng/internal mirror definitions are disabled, and the PAT is being removed from the Helix service secret manifest in parallel.
Refs: AB#10088