JobMonitor: preserve source metadata from job properties when resubmitting Helix work items#16908
JobMonitor: preserve source metadata from job properties when resubmitting Helix work items#16908Copilot wants to merge 5 commits into
Conversation
|
@copilot Look into how job properties are structured. I believe that all of the source properties you're trying to parse are part of the property bag. |
Updated to source these fields from the original job property bag first, then fall back to parsing |
|
@copilot Do NOT fall back to parsing source. |
| }; | ||
| if (TryGetSourceMetadataFromProperties(details.Properties, out string sourcePrefix, out string teamProject, out string repository, out string branch)) | ||
| { | ||
| creationRequest.SourcePrefix = sourcePrefix; |
There was a problem hiding this comment.
Because Helix rejects requests that include both Source and any of SourcePrefix/TeamProject/Repository/Branch (400). We mirror the SDK behavior here: use the split source fields when available; otherwise set Source.
Resubmitted Helix jobs from JobMonitor were missing SDK-populated source metadata (
Repository,Branch,SourcePrefix,TeamProject). This change aligns resubmission payload construction with Helix SDK submissions by using source metadata from the original job property bag, without parsingSource.Source metadata handling
SourcePrefix,TeamProject,Repository,Branch) when constructing the resubmissionJobCreationRequest.Sourceand source-component fields together.Compatibility fallback
Sourcedirectly.Targeted test coverage
Sourcepassthrough (noSourceparsing fallback).To double check: