[release/10.0] Remove legacyCredential PAT usage from Arcade templates#16921
Open
missymessa wants to merge 1 commit into
Open
[release/10.0] Remove legacyCredential PAT usage from Arcade templates#16921missymessa wants to merge 1 commit into
missymessa wants to merge 1 commit into
Conversation
…-sources calls Backport of main PR #16920. The enable-internal-sources.yml template already handles DevDiv projects by using the 'dnceng-artifacts-feeds-read' federated service connection. Fixes AB#10143
Contributor
There was a problem hiding this comment.
Pull request overview
This PR backports the removal of PAT-based legacyCredential usage from shared Arcade pipeline templates, allowing DevDiv feed authentication to use the WIF-backed dnceng-artifacts-feeds-read service connection path already built into enable-internal-sources.yml.
Changes:
- Removes explicit
legacyCredentialpassing from post-build Darc publishing. - Removes DevDiv-only
legacyCredentialpassing from build asset publishing. - Leaves the underlying template backwards-compatible for other callers that still pass
legacyCredential.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
eng/common/core-templates/post-build/post-build.yml |
Stops forcing PAT-based internal source setup before Darc publishing. |
eng/common/core-templates/job/publish-build-assets.yml |
Stops using the DevDiv PAT override when enabling internal sources for asset publishing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #16920 to release/10.0.
Removes the legacyCredential parameter from enable-internal-sources.yml calls, allowing DevDiv pipelines to use the WIF-backed
dnceng-artifacts-feeds-readservice connection instead of the PAT.Fixes AB#10143