JobMonitor: Use fluent assertions to handle random order of results#16941
Open
premun wants to merge 2 commits into
Open
JobMonitor: Use fluent assertions to handle random order of results#16941premun wants to merge 2 commits into
premun wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Helix JobMonitor-related tests to use AwesomeAssertions equivalency assertions so validations are insensitive to nondeterministic ordering, reducing test flakiness in the Helix SDK test suite.
Changes:
- Replace order-dependent
Assert.Equal(...Order())patterns withShould().BeEquivalentTo(...)for uploaded job names. - Replace explicit sorting for cancellation assertions with order-insensitive equivalency assertions.
- Update AzureDevOpsService test to validate processed job names without ordering.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Microsoft.DotNet.Helix/Sdk.Tests/Microsoft.DotNet.Helix.Sdk.Tests/JobMonitorRunnerTests.cs | Switches multiple assertions on job-name collections to order-insensitive equivalency checks to avoid random-order test failures. |
| src/Microsoft.DotNet.Helix/Sdk.Tests/Microsoft.DotNet.Helix.Sdk.Tests/AzureDevOpsServiceTests.cs | Uses order-insensitive equivalency for processed Helix job name set assertions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves problems with comparing results that come in asynchronously