Skip to content

JobMonitor: Use fluent assertions to handle random order of results#16941

Open
premun wants to merge 2 commits into
dotnet:mainfrom
premun:jobmonitor/use-awesomeassertions
Open

JobMonitor: Use fluent assertions to handle random order of results#16941
premun wants to merge 2 commits into
dotnet:mainfrom
premun:jobmonitor/use-awesomeassertions

Conversation

@premun
Copy link
Copy Markdown
Member

@premun premun commented Jun 2, 2026

Resolves problems with comparing results that come in asynchronously

Copilot AI review requested due to automatic review settings June 2, 2026 12:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Helix JobMonitor-related tests to use AwesomeAssertions equivalency assertions so validations are insensitive to nondeterministic ordering, reducing test flakiness in the Helix SDK test suite.

Changes:

  • Replace order-dependent Assert.Equal(...Order()) patterns with Should().BeEquivalentTo(...) for uploaded job names.
  • Replace explicit sorting for cancellation assertions with order-insensitive equivalency assertions.
  • Update AzureDevOpsService test to validate processed job names without ordering.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Microsoft.DotNet.Helix/Sdk.Tests/Microsoft.DotNet.Helix.Sdk.Tests/JobMonitorRunnerTests.cs Switches multiple assertions on job-name collections to order-insensitive equivalency checks to avoid random-order test failures.
src/Microsoft.DotNet.Helix/Sdk.Tests/Microsoft.DotNet.Helix.Sdk.Tests/AzureDevOpsServiceTests.cs Uses order-insensitive equivalency for processed Helix job name set assertions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants