Skip to content

Use deterministic values for _BuildNumber #16954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
omajid wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −1
Open

Use deterministic values for _BuildNumber #16954

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c09ac2f
Use deterministic values for _BuildNumber
omajid Jun 2, 2026
3fb9055
Use DateTime.UtcNow instead of Now for _BuildNumber
omajid Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/Microsoft.DotNet.Arcade.Sdk/tools/Version.BeforeCommonTargets.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@
<IsShippingVsix Condition="'$(IsShippingVsix)' == ''">$(IsShipping)</IsShippingVsix>
</PropertyGroup>

<PropertyGroup>
<DeterministicTimestamp Condition="'$(DeterministicTimestamp)' == '' and '$(SOURCE_DATE_EPOCH)' != ''">$(SOURCE_DATE_EPOCH)</DeterministicTimestamp>
</PropertyGroup>

<!--
Specification: https://github.com/dotnet/arcade/blob/master/Documentation/CorePackages/Versioning.md

Expand All @@ -44,7 +48,10 @@
and should only be enabled when it's necessary to test-install the MSIs produced by the build.
-->
<_BuildNumber>$(OfficialBuildId)</_BuildNumber>
<_BuildNumber Condition="'$(OfficialBuildId)' == ''">$([System.DateTime]::Now.ToString(yyyyMMdd)).1</_BuildNumber>
<!-- Use DeterministicTimestamp before falling back to wall-clock -->
<_BuildNumber Condition="'$(_BuildNumber)' == '' and '$(DeterministicTimestamp)' != '' and '$(DeterministicTimestamp)' != 'true' and '$(DeterministicTimestamp)' != 'false' and !$(DeterministicTimestamp.Contains('-'))">$([System.DateTimeOffset]::FromUnixTimeSeconds($(DeterministicTimestamp)).UtcDateTime.ToString(yyyyMMdd)).1</_BuildNumber>
<_BuildNumber Condition="'$(_BuildNumber)' == '' and $(DeterministicTimestamp.Contains('-'))">$([System.DateTimeOffset]::Parse($(DeterministicTimestamp)).UtcDateTime.ToString(yyyyMMdd)).1</_BuildNumber>
<_BuildNumber Condition="'$(_BuildNumber)' == ''">$([System.DateTime]::UtcNow.ToString(yyyyMMdd)).1</_BuildNumber>

<!--
OfficialBuildId is assumed to have format "20yymmdd.r" (the assumption is checked later in a target).
Expand Down
Loading