Skip to content

feat: add missing [StringSyntax(DateTimeFormat)] to DateTimeOffset methods in BindConverter #66532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Youssef1313 merged 4 commits into from
May 13, 2026
+4 −4
Merged

feat: add missing [StringSyntax(DateTimeFormat)] to DateTimeOffset methods in BindConverter #66532

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a905e8f
feat: add [StringSyntax(DateTimeFormat)] to DateTimeOffset methods in…
EduardF1 Apr 29, 2026
788a87f
Merge branch 'main' into feat/stringsyntax-remaining-formats
EduardF1 May 8, 2026
52e3d65
ci: retrigger pipelines
EduardF1 May 9, 2026
feaceb5
Merge branch 'main' into feat/stringsyntax-remaining-formats
EduardF1 May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Components/Components/src/BindConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ private static string FormatDateTimeValueCore(DateTime value, CultureInfo? cultu
/// </param>
/// <returns>The formatted value.</returns>
[SuppressMessage("ApiDesign", "RS0026:Do not add multiple public overloads with optional parameters", Justification = "Required to maintain compatibility")]
public static string FormatValue(DateTimeOffset value, string format, CultureInfo? culture = null) => FormatDateTimeOffsetValueCore(value, format, culture);
public static string FormatValue(DateTimeOffset value, [StringSyntax(StringSyntaxAttribute.DateTimeFormat)] string format, CultureInfo? culture = null) => FormatDateTimeOffsetValueCore(value, format, culture);

private static string FormatDateTimeOffsetValueCore(DateTimeOffset value, string? format, CultureInfo? culture)
{
Expand Down Expand Up @@ -460,7 +460,7 @@ private static string FormatDateTimeOffsetValueCore(DateTimeOffset value, Cultur
/// </param>
/// <returns>The formatted value.</returns>
[SuppressMessage("ApiDesign", "RS0026:Do not add multiple public overloads with optional parameters", Justification = "Required to maintain compatibility")]
public static string? FormatValue(DateTimeOffset? value, string format, CultureInfo? culture = null) => FormatNullableDateTimeOffsetValueCore(value, format, culture);
public static string? FormatValue(DateTimeOffset? value, [StringSyntax(StringSyntaxAttribute.DateTimeFormat)] string format, CultureInfo? culture = null) => FormatNullableDateTimeOffsetValueCore(value, format, culture);

private static string? FormatNullableDateTimeOffsetValueCore(DateTimeOffset? value, string? format, CultureInfo? culture)
{
Expand Down Expand Up @@ -1297,7 +1297,7 @@ public static bool TryConvertToDateTimeOffset(object? obj, CultureInfo? culture,
/// <param name="format">The format string to use in conversion.</param>
/// <param name="value">The converted value.</param>
/// <returns><c>true</c> if conversion is successful, otherwise <c>false</c>.</returns>
public static bool TryConvertToDateTimeOffset(object? obj, CultureInfo? culture, string format, out DateTimeOffset value)
public static bool TryConvertToDateTimeOffset(object? obj, CultureInfo? culture, [StringSyntax(StringSyntaxAttribute.DateTimeFormat)] string format, out DateTimeOffset value)
{
return ConvertToDateTimeOffsetCore(obj, culture, format, out value);
}
Expand All @@ -1322,7 +1322,7 @@ public static bool TryConvertToNullableDateTimeOffset(object? obj, CultureInfo?
/// <param name="format">The format string to use in conversion.</param>
/// <param name="value">The converted value.</param>
/// <returns><c>true</c> if conversion is successful, otherwise <c>false</c>.</returns>
public static bool TryConvertToNullableDateTimeOffset(object? obj, CultureInfo? culture, string format, out DateTimeOffset? value)
public static bool TryConvertToNullableDateTimeOffset(object? obj, CultureInfo? culture, [StringSyntax(StringSyntaxAttribute.DateTimeFormat)] string format, out DateTimeOffset? value)
{
return ConvertToNullableDateTimeOffsetCore(obj, culture, format, out value);
}
Expand Down
Loading