-
Notifications
You must be signed in to change notification settings - Fork 92
[Version 9.0] Feature support for more partial methods #1468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BillWagner
wants to merge
10
commits into
draft-v9
Choose a base branch
from
v9-more-partial-methods
base: draft-v9
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
2ced0d0
Add support for extending partial methods
RexJaeschke 89f4c4d
Address existing comments.
BillWagner 5839c04
Some final edits
BillWagner 2e5175a
Apply suggestions from code review
BillWagner 1e68822
Respond to meeting feedback
BillWagner 2a11484
fix build issues
BillWagner 85d860e
Apply suggestions from code review
BillWagner 5f9ccc3
Respond to feedback.
BillWagner 4f0e0e3
missed a couple...
BillWagner fbe81a5
review and edit.
BillWagner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -397,7 +397,7 @@ | |
| : 'where' type_parameter ':' type_parameter_constraints | ||
| ; | ||
|
|
||
| type_parameter_constraints | ||
| : primary_constraint (',' secondary_constraints)? (',' constructor_constraint)? | ||
| | secondary_constraints (',' constructor_constraint)? | ||
| | constructor_constraint | ||
|
|
@@ -506,15 +506,15 @@ | |
| > static void M() | ||
| > { | ||
| > // nonnull constraint allows nonnullable struct type argument | ||
| > A<int> x1; | ||
| > // possible warning: nonnull constraint prohibits nullable struct type argument | ||
| > A<int?> x2; | ||
| > // nonnull constraint allows nonnullable class type argument | ||
| > A<C> x3; | ||
| > // possible warning: nonnull constraint prohibits nullable class type argument | ||
| > A<C?> x4; | ||
| > // nonnullable base class requirement allows nonnullable class type argument | ||
| > B1<C> x5; | ||
| > // possible warning: nonnullable base class requirement prohibits nullable | ||
| > // class type argument | ||
| > B1<C?> x6; | ||
|
|
@@ -2074,7 +2074,7 @@ | |
| ; | ||
|
|
||
| ref_method_modifiers | ||
| : ref_method_modifier* | ||
| : ref_method_modifier* 'partial'? | ||
| ; | ||
|
|
||
| method_header | ||
|
|
@@ -2151,15 +2151,16 @@ | |
| - The declaration may include the `abstract` and `override` modifiers so that an abstract member may override a virtual member. | ||
| - If the declaration includes the `private` modifier, then the declaration does not include any of the following modifiers: `virtual`, `override`, or `abstract`. | ||
| - If the declaration includes the `sealed` modifier, then the declaration also includes the `override` modifier. | ||
| - If the declaration includes the `partial` modifier, then it does not include any of the following modifiers: `new`, `public`, `protected`, `internal`, `private`, `virtual`, `sealed`, `override`, `abstract`, or `extern`. | ||
| - If the declaration includes the `partial` modifier, then it does not include the modifier `abstract`. | ||
| - If the declaration is for an optional partial method (§optional-partial-methods), then it does not include any of the following modifiers: `new`, `public`, `protected`, `internal`, `private`, `virtual`, `sealed`, `override`, or `extern`. | ||
|
|
||
| Methods are classified according to what, if anything, they return: | ||
|
|
||
| - If `ref` is present, the method is ***returns-by-ref*** and returns a *variable reference*, that is optionally read-only; | ||
| - Otherwise, if *return_type* is `void`, the method is ***returns-no-value*** and does not return a value; | ||
| - Otherwise, the method is ***returns-by-value*** and returns a value. | ||
|
|
||
| The *return_type* of a returns-by-value or returns-no-value method declaration specifies the type of the result, if any, returned by the method. Only a returns-no-value method may include the `partial` modifier ([§15.6.9](classes.md#1569-partial-methods)). If the declaration includes the `async` modifier then *return_type* shall be `void` or the method returns-by-value and the return type is a *task type* ([§15.14.1](classes.md#15141-general)). | ||
| The *return_type* of a returns-by-value or returns-no-value method declaration specifies the type of the result, if any, returned by the method. If the declaration includes the `async` modifier then *return_type* shall be `void` or the method returns-by-value and the return type shall be a *task type* ([§15.14.1](classes.md#15141-general)). | ||
|
|
||
| The *ref_return_type* of a returns-by-ref method declaration specifies the type of the variable referenced by the *variable_reference* returned by the method. | ||
|
|
||
|
|
@@ -2183,7 +2184,7 @@ | |
|
|
||
| The *ref_method_body* of a returns-by-ref method is either a semicolon, a block body or an expression body. A block body consists of a *block*, which specifies the statements to execute when the method is invoked. An expression body consists of `=>`, followed by `ref`, a *variable_reference*, and a semicolon, and denotes a single *variable_reference* to evaluate when the method is invoked. | ||
|
|
||
| For abstract and extern methods, the *ref_method_body* consists simply of a semicolon; for all other methods, the *ref_method_body* is either a block body or an expression body. | ||
| For abstract and extern methods, the *ref_method_body* consists simply of a semicolon. For partial methods the *ref_method_body* may consist of either a semicolon, a block body or an expression body. For all other methods, the *ref_method_body* is either a block body or an expression body. | ||
|
|
||
| The name, the number of type parameters, and the parameter list of a method define the signature ([§7.6](basic-concepts.md#76-signatures-and-overloading)) of the method. Specifically, the signature of a method consists of its name, the number of its type parameters, and the number, *parameter_mode_modifier*s ([§15.6.2.1](classes.md#15621-general)), and types of its parameters. The return type is not part of a method’s signature, nor are the names of the parameters, the names of the type parameters, or the constraints. When a parameter type references a type parameter of the method, the ordinal position of the type parameter (not the name of the type parameter) is used for type equivalence. | ||
|
|
||
|
|
@@ -2388,7 +2389,7 @@ | |
|
|
||
| A parameter declared with an `out` modifier is an ***output parameter***. For definite-assignment rules, see [§9.2.7](variables.md#927-output-parameters). | ||
|
|
||
| A method declared as a partial method ([§15.6.9](classes.md#1569-partial-methods)) shall not have output parameters. | ||
| A method declared as an optional partial method (§optional-partial-methods) shall not have output parameters. | ||
|
|
||
| > *Note*: Output parameters are typically used in methods that produce multiple return values. *end note* | ||
| <!-- markdownlint-disable MD028 --> | ||
|
|
@@ -3026,22 +3027,53 @@ | |
|
|
||
| ### 15.6.9 Partial methods | ||
|
|
||
| When a method declaration includes a `partial` modifier, that method is said to be a ***partial method***. Partial methods may only be declared as members of partial types ([§15.2.7](classes.md#1527-partial-type-declarations)), and are subject to a number of restrictions. | ||
| #### §partial-methods-general General | ||
|
|
||
| Partial methods may be defined in one part of a type declaration and implemented in another. The implementation is optional; if no part implements the partial method, the partial method declaration and all calls to it are removed from the type declaration resulting from the combination of the parts. | ||
| When a *method declaration* includes a `partial` modifier, that method is said to be a ***partial method***. Partial methods may only be declared as members of partial types ([§15.2.7](classes.md#1527-partial-type-declarations)). Partial methods may be defined in one part of a type declaration and implemented in another. | ||
|
|
||
| Partial methods shall not define access modifiers; they are implicitly private. Their return type shall be `void`, and their parameters shall not be output parameters. The identifier `partial` is recognized as a contextual keyword ([§6.4.4](lexical-structure.md#644-keywords)) in a method declaration only if it appears immediately before the `void` keyword. A partial method cannot explicitly implement interface methods. | ||
| In *method_declaration*, the identifier `partial` is recognized as a contextual keyword ([§6.4.4](lexical-structure.md#644-keywords)) only if it immediately precedes the *return_type*. A partial method cannot explicitly implement interface methods. | ||
|
|
||
| There are two kinds of partial method declarations: If the body of the method declaration is a semicolon, the declaration is said to be a ***defining partial method declaration***. If the body is other than a semicolon, the declaration is said to be an ***implementing partial method declaration***. Across the parts of a type declaration, there shall be only one defining partial method declaration with a given signature, and there shall be at most only one implementing partial method declaration with a given signature. If an implementing partial method declaration is given, a corresponding defining partial method declaration shall exist, and the declarations shall match as specified in the following: | ||
| Partial method declarations are classified as follows: | ||
|
|
||
| - A method with an *expression-body* or a *block-body* or is declared with the `extern` modifier is said to be an ***implementing partial method declaration***. | ||
| - Otherwise, a method declaration where the body of the method declaration is a semicolon is said to be a ***defining partial method declaration***. | ||
|
|
||
| Across the parts of a type declaration, there shall be exactly one defining partial method declaration with a given signature. If an implementing partial method declaration is given, a corresponding defining partial method declaration shall exist, and the declarations shall match as specified in the following: | ||
|
|
||
| - The declarations shall have the same method name, number of type parameters, and number of parameters. | ||
| - The declarations shall have the same modifiers (although not necessarily in the same order), with the exception of the `async` modifier which shall not appear on a defining part. | ||
| - Corresponding parameters in the declarations shall have the same modifiers (although not necessarily in the same order) and the same types, or identity convertible types (modulo differences in type parameter names). | ||
| - Corresponding type parameters in the declarations shall have the same constraints (modulo differences in type parameter names). | ||
| - The declarations shall have the same modifiers except for the `async` and `extern` modifiers. The `async` and `extern` modifiers are allowed only on the implementing partial method declaration. | ||
| - Corresponding parameters in the declarations shall have the same modifiers (although not necessarily in the same order) and the same types (modulo differences in type parameter names). Tuple types (§8.3.11) used as parameters or return types shall have the same item names in both the defining and implementing partial method declarations. | ||
| - Corresponding type parameters in the declarations shall have the same constraints. An implementation may choose to issue a warning if the type parameter names are different in the defining and implementing declarations. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need this bit about warnings? (I think we generally say implementations can issue warnings whenever they want.) |
||
|
|
||
| An implementing partial method declaration can appear in the same part as the corresponding defining partial method declaration. | ||
| There are two variations of partial methods: required and optional. A ***required partial method*** (§required-partial-methods) is a partial method that includes one or more explicit access modifiers. An ***optional partial method*** (§optional-partial-methods) has no explicit access modifiers, and is implicitly private. | ||
|
|
||
| Only a defining partial method participates in overload resolution. Thus, whether or not an implementing declaration is given, invocation expressions may resolve to invocations of the partial method. Because a partial method always returns `void`, such invocation expressions will always be expression statements. Furthermore, because a partial method is implicitly `private`, such statements will always occur within one of the parts of the type declaration within which the partial method is declared. | ||
| For a required partial method both the definition and implementation shall exist. | ||
|
|
||
| > *Example*: | ||
| > | ||
| > <!-- Example: {template:"standalone-lib-without-using", name:"PartialMethods2", replaceEllipsis:true, customEllipsisReplacements: ["", "return true;", "i = 10;"]} --> | ||
| > ```csharp | ||
| > // part containing defining partial method declarations | ||
| > partial class C | ||
| > { | ||
| > partial void M1(); // implementation optional | ||
| > private partial void M2(); // required, impl. required | ||
| > protected partial bool M3(); // required, impl. required | ||
| > public partial void M4(out int i); // required, impl. required | ||
| > } | ||
| > | ||
| > // part containing implementing partial method declarations | ||
| > partial class C | ||
| > { | ||
| > private partial void M2() { ... } | ||
| > protected partial bool M3() { ... } | ||
| > public partial void M4(out int i) { ... } | ||
| > } | ||
| > ``` | ||
| > | ||
| > *end example* | ||
|
|
||
| Only a defining partial method participates in overload resolution. | ||
|
|
||
| > *Note*: The definition of matching defining and implementing partial method declarations does not require parameter names to match. This can produce *surprising*, albeit *well defined*, behaviour when named arguments ([§12.6.2.1](expressions.md#12621-general)) are used. For example, given the defining partial method declaration for `M` in one file, and the implementing partial method declaration in another file: | ||
| > | ||
|
|
@@ -3065,25 +3097,12 @@ | |
| > | ||
| > *end note* | ||
|
|
||
| If no part of a partial type declaration contains an implementing declaration for a given partial method, any expression statement invoking it is simply removed from the combined type declaration. Thus the invocation expression, including any subexpressions, has no effect at run-time. The partial method itself is also removed and will not be a member of the combined type declaration. | ||
|
|
||
| If an implementing declaration exists for a given partial method, the invocations of the partial methods are retained. The partial method gives rise to a method declaration similar to the implementing partial method declaration except for the following: | ||
|
|
||
| - The `partial` modifier is not included. | ||
|
|
||
| - The `partial` modifier is not included in the combined method declaration. | ||
| - The attributes in the resulting method declaration are the combined attributes of the defining and the implementing partial method declaration in unspecified order. Duplicates are not removed. | ||
|
|
||
| - The attributes on the parameters of the resulting method declaration are the combined attributes of the corresponding parameters of the defining and the implementing partial method declaration in unspecified order. Duplicates are not removed. | ||
|
|
||
| If a defining declaration but not an implementing declaration is given for a partial method `M`, the following restrictions apply: | ||
|
|
||
| - It is a compile-time error to create a delegate from `M` ([§12.8.17.5](expressions.md#128175-delegate-creation-expressions)). | ||
|
|
||
| - It is a compile-time error to refer to `M` inside an anonymous function that is converted to an expression tree type ([§8.6](types.md#86-expression-tree-types)). | ||
|
|
||
| - Expressions occurring as part of an invocation of `M` do not affect the definite assignment state ([§9.4](variables.md#94-definite-assignment)), which can potentially lead to compile-time errors. | ||
|
|
||
| - `M` cannot be the entry point for an application ([§7.1](basic-concepts.md#71-application-startup)). | ||
| - Any default arguments (§15.6.2) in the implementing declaration are removed. | ||
|
|
||
| Partial methods are useful for allowing one part of a type declaration to customize the behavior of another part, e.g., one that is generated by a tool. Consider the following partial class declaration: | ||
|
|
||
|
|
@@ -3167,6 +3186,31 @@ | |
| } | ||
| ``` | ||
|
|
||
| #### §optional-partial-methods Optional partial methods | ||
|
|
||
| An optional partial method shall have a `void` return type, and shall not declare out parameters. There shall be zero or one implementing declaration for each defining declaration. If no part implements the partial method, the partial method declaration and all calls to it are removed from the type declaration resulting from the combination of the parts. Whether or not an implementing declaration is given, invocation expressions may resolve to invocations of the partial method. | ||
|
|
||
| The implementing member for an optional partial method shall not be an external method (§15.6.8). | ||
|
|
||
| > *Note*: Because an optional partial method always returns `void`, such invocation expressions will always be expression statements. Furthermore, because an optional partial method is implicitly `private`, such statements will always occur within one of the parts of the type declaration within which the partial method is declared. *end note* | ||
|
|
||
| If an optional partial method has no implementation, any expression statement invoking it is removed from the combined type declaration. Thus, the invocation expression, including any subexpressions, has no effect at run-time. The partial method itself is also removed and will not be a member of the combined type declaration. | ||
|
|
||
| If a defining declaration but not an implementing declaration is given for an optional partial method `M`, the following restrictions apply: | ||
|
|
||
| - It is a compile-time error to create a delegate from `M` ([§12.8.17.5](expressions.md#128175-delegate-creation-expressions)). | ||
| - It is a compile-time error to refer to `M` inside an anonymous function that is converted to an expression tree type ([§8.6](types.md#86-expression-tree-types)). | ||
| - Expressions occurring as part of an invocation of `M` do not affect the definite assignment state ([§9.4](variables.md#94-definite-assignment)), which can potentially lead to compile-time errors. | ||
| - `M` cannot be the entry point for an application ([§7.1](basic-concepts.md#71-application-startup)). | ||
|
|
||
| #### §required-partial-methods Required partial methods | ||
|
|
||
| A required partial method declaration includes an explicit access modifier. There shall be exactly one implementing partial method declaration. | ||
|
|
||
| The implementing declaration for a required partial method may be an external method (§15.6.8). The `extern` modifier is allowed on an implementing partial declaration. It shall not be present on a defining partial declaration. | ||
|
|
||
| > *Note:* The `private` access modifier is required on both the ***defining partial method declaration*** and the ***implementing partial method declaration*** of a private required partial method. *end note* | ||
|
|
||
| ### 15.6.10 Extension methods | ||
|
|
||
| When the first parameter of a method includes the `this` modifier, that method is said to be an ***extension method***. Extension methods shall only be declared in non-generic, non-nested static classes. The first parameter of an extension method is restricted, as follows: | ||
|
|
@@ -3465,7 +3509,7 @@ | |
| > static void Main() | ||
| > { | ||
| > field = 10; | ||
| > Console.WriteLine(Property); // Prints 10 | ||
| > Property = 20; // This invokes the get accessor, then assigns | ||
| > // via the resulting variable reference | ||
| > Console.WriteLine(field); // Prints 20 | ||
|
|
@@ -4234,7 +4278,7 @@ | |
|
|
||
| The accessor declarations consist of an *add_accessor_declaration* and a *remove_accessor_declaration*. Each accessor declaration consists of the token add or remove followed by a *block*. The *block* associated with an *add_accessor_declaration* specifies the statements to execute when an event handler is added, and the *block* associated with a *remove_accessor_declaration* specifies the statements to execute when an event handler is removed. | ||
|
|
||
| Each *add_accessor_declaration* and *remove_accessor_declaration* corresponds to a method with a single value parameter of the event type, and a `void` return type. The implicit parameter of an event accessor is named `value`. When an event is used in an event assignment, the appropriate event accessor is used. Specifically, if the assignment operator is `+=` then the add accessor is used, and if the assignment operator is `–=` then the remove accessor is used. In either case, the right operand of the assignment operator is used as the argument to the event accessor. The block of an *add_accessor_declaration* or a *remove_accessor_declaration* shall conform to the rules for `void` methods described in [§15.6.9](classes.md#1569-partial-methods). In particular, `return` statements in such a block are not permitted to specify an expression. | ||
| Each *add_accessor_declaration* and *remove_accessor_declaration* corresponds to a method with a single value parameter of the event type, and a `void` return type. The implicit parameter of an event accessor is named `value`. When an event is used in an event assignment, the appropriate event accessor is used. Specifically, if the assignment operator is `+=` then the add accessor is used, and if the assignment operator is `–=` then the remove accessor is used. In either case, the right operand of the assignment operator is used as the argument to the event accessor. The block of an *add_accessor_declaration* or a *remove_accessor_declaration* shall conform to the rules for `void` methods described in [§15.6.11](classes.md#15611-method-body). In particular, `return` statements in such a block are not permitted to specify an expression. | ||
|
|
||
| Since an event accessor implicitly has a parameter named `value`, it is a compile-time error for a local variable or constant declared in an event accessor to have that name. | ||
|
|
||
|
|
@@ -4580,7 +4624,7 @@ | |
| : '!' | ||
| ; | ||
|
|
||
| overloadable_unary_operator | ||
| : '+' | '-' | logical_negation_operator | '~' | '++' | '--' | 'true' | 'false' | ||
| ; | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.