Post #681 review and grammar testing update#1473
Merged
jskeet merged 2 commits intodotnet:draft-v8from Dec 17, 2025
Merged
Conversation
- dotnet#681 has been merged before completion to reduce the conversation & change complexity. This is a review of this PR changes now in draft-v8. Every change will be augmented by a comment in the new PR - Grammar testing, updates post dotnet#681 - Update tarball to v2.3.7 - Add sample “Expanded Interfaces”
Nigel-Ecma
commented
Nov 17, 2025
Nigel-Ecma
commented
Nov 17, 2025
Nigel-Ecma
commented
Nov 17, 2025
Nigel-Ecma
commented
Nov 17, 2025
Nigel-Ecma
commented
Nov 17, 2025
Nigel-Ecma
commented
Nov 17, 2025
Nigel-Ecma
commented
Nov 17, 2025
Nigel-Ecma
commented
Nov 17, 2025
Nigel-Ecma
commented
Nov 17, 2025
Nigel-Ecma
commented
Nov 17, 2025
Contributor
Author
|
Closing & reopening to refresh tools |
Contributor
Author
|
Reopening with refreshed tools… |
BillWagner
reviewed
Nov 17, 2025
Member
BillWagner
left a comment
BillWagner
left a comment
There was a problem hiding this comment.
This is good. I upvoted all the standard changes I agreed with, and added comments on the few others I had feedback on.
jskeet
reviewed
Nov 19, 2025
jnm2
reviewed
Nov 19, 2025
Nigel-Ecma
commented
Nov 20, 2025
Contributor
Author
|
Close & reopen to refresh tools |
Contributor
Author
|
Reopen… |
BillWagner
approved these changes
Dec 1, 2025
Member
BillWagner
left a comment
BillWagner
left a comment
There was a problem hiding this comment.
This LGTM, but leaving unmerged in case others have better word suggestions for that final edit.
BillWagner
added
the
meeting: priority
Member
|
Adding the meeting-priority label to make sure we discuss and take action at our next meeing. |
jskeet
added
the
meeting: discuss
Contributor
|
(Added meeting discuss as I'm skipping "meeting priority" for this meeting... we've got few enough PRs and issues to look at.) |
jskeet
approved these changes
Dec 10, 2025
jnm2
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review: #681 has been merged before completion to reduce the conversation & change complexity. This is a review of this PR’s changes now in draft-v8. Every change will be augmented by a comment in this new PR
Grammar testing: Add sample “Expanded Interfaces” to cover #681 changes. Update tarball to v2.3.7
Review notes:
The changes to files in /standard should be read as “review suggestions” – as in the changes may, or may not, be accepted. Each one is commented.
Of all the other files the only one you may wish to read is /tools/GrammarTesting/Tests/Parsing/Samples/v8/Expanded Interfaces/sample.cs. This is the trivial sample added to check that all the new members of interfaces are parsed as expected.