Describe the impact of ? on arrays of arrays#1554
Conversation
|
I'm fully expecting there to be some more work here, but I'm hoping it's at least close. |
|
@Nigel-Ecma: I believe the grammar test failure is now a matter of changing the expected tokens (due to the introduction of non_array_non_nullable_type) - let me know if this is something I can fix myself, or whether it needs your help :) |
BillWagner
left a comment
There was a problem hiding this comment.
I like this approach. I have a couple comments to consider and discuss.
Nigel-Ecma
left a comment
There was a problem hiding this comment.
I’ve made a few comments but obviously there is a fair bit to go yet – e.g. conversions. Some of it is still confusing, but it seems a good start to dressing this up ;-)
With the proviso that I haven’t downloaded this and run the failing tests it does look like the errors reported are valid changes in the expect parse due to the revised grammar. If this is the case then it will just need a few updates to the “reference” parse files (the ones that are machine generated and ignored in PR reviews). You can generate them yourself but you might prefer one of us with the tools already downloaded to run and produce them does it! It can wait until the PR is approved and before it is merged. |
Co-authored-by: Nigel-Ecma <6654683+Nigel-Ecma@users.noreply.github.com>
|
Next steps:
|
BillWagner
left a comment
There was a problem hiding this comment.
Let's
based on our discussion in the meeting.
Alternative to #1386.
Fixes #1385.