Skip to content

Describe the impact of ? on arrays of arrays#1554

Open
jskeet wants to merge 8 commits intodraft-v8from
multi-dimensional-arrays
Open

Describe the impact of ? on arrays of arrays#1554
jskeet wants to merge 8 commits intodraft-v8from
multi-dimensional-arrays

Conversation

@jskeet
Copy link
Contributor

@jskeet jskeet commented Jan 27, 2026

Alternative to #1386.

Fixes #1385.

@jskeet
Copy link
Contributor Author

jskeet commented Jan 27, 2026

I'm fully expecting there to be some more work here, but I'm hoping it's at least close.

@jskeet jskeet added the meeting: discuss This issue should be discussed at the next TC49-TG2 meeting label Jan 27, 2026
@jskeet
Copy link
Contributor Author

jskeet commented Jan 27, 2026

@Nigel-Ecma: I believe the grammar test failure is now a matter of changing the expected tokens (due to the introduction of non_array_non_nullable_type) - let me know if this is something I can fix myself, or whether it needs your help :)

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this approach. I have a couple comments to consider and discuss.

Copy link
Contributor

@Nigel-Ecma Nigel-Ecma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve made a few comments but obviously there is a fair bit to go yet – e.g. conversions. Some of it is still confusing, but it seems a good start to dressing this up ;-)

@Nigel-Ecma
Copy link
Contributor

@Nigel-Ecma: I believe the grammar test failure is now a matter of changing the expected tokens (due to the introduction of non_array_non_nullable_type) - let me know if this is something I can fix myself, or whether it needs your help :)

With the proviso that I haven’t downloaded this and run the failing tests it does look like the errors reported are valid changes in the expect parse due to the revised grammar.

If this is the case then it will just need a few updates to the “reference” parse files (the ones that are machine generated and ignored in PR reviews). You can generate them yourself but you might prefer one of us with the tools already downloaded to run and produce them does it! It can wait until the PR is approved and before it is merged.

jskeet and others added 2 commits February 11, 2026 20:50
Co-authored-by: Nigel-Ecma <6654683+Nigel-Ecma@users.noreply.github.com>
@jskeet
Copy link
Contributor Author

jskeet commented Feb 11, 2026

Next steps:

  • Nigel to email Jon the files to add to this PR to get the grammar checker passing
  • Jon will update this PR, then merge.
  • Jon to file a new issue around mapping between nullable and non-nullable arrays, see Allow arrays of nullable reference types #1386, to also include conversions - and anything else folks think is missing
  • Jon will hopefully create a new PR to address that

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's :shipit: based on our discussion in the meeting.

@BillWagner BillWagner dismissed Nigel-Ecma’s stale review February 11, 2026 21:21

Per meeting discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meeting: discuss This issue should be discussed at the next TC49-TG2 meeting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Arrays of nullable references

3 participants